Code review comment for lp://staging/~jtv/launchpad/bug-711077

Jeroen--

Good improvements, especially the cleaning up of the TAL.

Your tests have a recurring use of makePerson (as user in one block, as author in another) that could be done once in setUp and then reused, which would speed up the testcase.

There are a variety of other calls to makePerson which I think are only to make sure a person other than the user is involved; those could probably also be replaced by creating one other person in setUp and reusing that person.

Otherwise, this looks good.

I'm marking as Approve so you're not blocked on this when you start your day, but I would really like to see the TestCase changes made.