Code review comment for lp://staging/~jtv/launchpad/bug-418430-stuff-to-review-3.0

Revision history for this message
Deryck Hodge (deryck) wrote :

> One note about the UI, when I looked at the page itself, the two
> headings -- the person name heading in an h2 and the page title in an
> h1 -- were in the same purple color used for translations currently.
> As I understand it, these should be light gray and green respectively.
> I assume there's some current 2.0 LP style rule making all headings
> this color for translations. The same is true of the bugs app, I
> know. So I just call your attention to it, if you're not already
> aware. Nothing to fix now, but at some point it has to be changed.
> Maybe you guys have already talked about this, but just in case not, I
> mention it.
>

So I made a bit of mistake here. I was thinking about the rule that the h2 should be gray, and blanked out for a minute that green is the registry color. So the h2 should be gray, and currently the h1 the app-specific color. I'm just updating the MP to admit my mistake if someone comes along later.

I did talk to beuno about this. And he does have some desire to have a single h1 color across apps. But that is a separate issue.

I filed bug 418666 about needing to have the context.title headings be gray across all app-specific pages.

Cheers,
deryck

« Back to merge proposal