Code review comment for lp://staging/~jspashett/bzr/587868_args_handling_cant_debug

Revision history for this message
Alexander Belchenko (bialix) wrote :

1) Your changes are conflicting with current state of bzr.dev. Please, merge lp:bzr into your branch and resolve conflicts. Then commit and push new state to lp.

2) I think you don't need additional function process_metachars_in_commandline, do you?

3) Why you have changed name of the function to _win32syscall_command_line_to_argv? What it should say to other people?

4) Don't use `raise AssertionError()`, use instead BzrInternalError.

review: Needs Fixing

« Back to merge proposal