Code review comment for lp://staging/~jseutter/charms/precise/storage/storage-with-broker-provider

Revision history for this message
Chad Smith (chad.smith) wrote :

> I'd like to re-review, but there seems to be some rework necessary here. I'd
> suggest for testing:
>
> 1) deploy
> 2) add-unit postgres
> 3) add-unit postgres
> 4) break relation between postgres and storage, add back

Without the subsequent MP, I don't think breaking storage/postgresql relations and re-adding will be possible because volume labels of block-storage-broker to storage will have been labeled "storage/0 unit volume" and when you readd the relation it would try to find a storage/1 or storage/2 labelled volume to remount. This is fixed in the storage-volume-label branch below

https://code.launchpad.net/~chad.smith/charms/precise/storage/storage-volume-label-and-volume-map/+merge/205669

« Back to merge proposal