Code review comment for lp://staging/~jseutter/charms/precise/cinder/ha-support-with-health

Revision history for this message
Jerry Seutter (jseutter) wrote :

> Same concerns here wrt the lax use of grep matching.

I'll fix that.

> Also, should you also be checking that the relevant API services are listening
> on their respective ports as well? Currently the branches configure the
> actual listening port dynamically based on the existence of haproxy, but there
> are a branch soon-to-land that will change this so that the service's
> listening port (as listed in the keystone catalog) will always be the default
> regardless of the current request pipeline (combination of HTTPS, haproxy,
> api-server) That is, cinder-api will always be listening on 8776, glance-api
> always on 9292, etc.

Thanks for pointing this out. I'll probably shelve this for now and wait for that branch to land.

> I'm happy to wait on this until those branches have landed, and you guys can
> continue to improve the health tests as you see fit moving forward, since I
> don't know what you have going on elsewhere.
>
> https://code.launchpad.net/~jseutter/charms/precise/glance/ha-support-with-
> health/+merge/151570

Yep, sounds good.

« Back to merge proposal