Code review comment for lp://staging/~josharenson/unity8/close-extra-panel-when-selected

Revision history for this message
Josh Arenson (josharenson) wrote :

> Looks good now.
>
> But to make it behave more like the real world we should have
>
> http://paste.ubuntu.com/16316839/
>
> on the mock plugin, so that actually when selecting a option the "navitgation
> block" shows up.
>
> Can you add that to this MR? Or you prefer we do it in a separate one?

I'll add it. It isn't necessary for this branch, but it is a small change and its more correct.

« Back to merge proposal