Code review comment for lp://staging/~josharenson/unity-scopes-shell/fix-overview-results-sorting

Revision history for this message
Josh Arenson (josharenson) wrote :

> Looks good to me, thanks!
>
> As discussed on IRC, it's not clear what made the previous implementation so
> slow (although the fact the 'i' wasn't incremented on every iteration could be
> part of the problem), but what you propose make sense and is an improvement,
> the tests are passing and I haven't found any regression with this change, so
> +1.
>
> One remark only, could you please remove the extra line before we land this:
> 32 + for (int i = 1; i < m_results.size(); i++) {
> 33 +

Removed the line and also changed "j -= 1" to "j--" as that was bothering me as well :-)

« Back to merge proposal