QtMir

Merge lp://staging/~josharenson/qtmir/disable_orientation_sensors_based_on_screen_state into lp://staging/qtmir

  1. disable_orientation_sensors_based_on_screen_state
  2. Merge into trunk
Proposed by Josh Arenson
Status: Merged
Approved by: Daniel d'Andrada
Approved revision: 274
Merged at revision: 279
Proposed branch: lp://staging/~josharenson/qtmir/disable_orientation_sensors_based_on_screen_state
Merge into: lp://staging/qtmir
Diff against target: 192 lines (+118/-3)
5 files modified
src/platforms/mirserver/screen.cpp (+28/-2)
src/platforms/mirserver/screen.h (+8/-0)
tests/mirserver/Screen/Screen.pro (+16/-0)
tests/mirserver/Screen/screen_test.cpp (+65/-0)
tests/mirserver/mirserver.pro (+1/-1)
To merge this branch: bzr merge lp://staging/~josharenson/qtmir/disable_orientation_sensors_based_on_screen_state
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Daniel d'Andrada (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+238606@code.staging.launchpad.net

Commit message

Add support for enabling/disabling orientation sensor based on screen power state.

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.
No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

Fix lp:1375297

This turns the orientation sensor on or off depending on the power state of the screen.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:269
http://jenkins.qa.ubuntu.com/job/qtmir-ci/142/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-utopic-amd64-ci/142
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-utopic-armhf-ci/142
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-utopic-armhf-ci/142/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/142/rebuild

review: Approve (continuous-integration)
lp://staging/~josharenson/qtmir/disable_orientation_sensors_based_on_screen_state updated
270. By Josh Arenson

Fix whitespace issues

271. By Josh Arenson

Remove leftover tab

272. By Josh Arenson

Add FIXME

273. By Josh Arenson

Fix whitespace

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:270
http://jenkins.qa.ubuntu.com/job/qtmir-ci/146/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-utopic-amd64-ci/146
    SUCCESS: http://jenkins.qa.ubuntu.com/job/qtmir-utopic-armhf-ci/146
        deb: http://jenkins.qa.ubuntu.com/job/qtmir-utopic-armhf-ci/146/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/qtmir-ci/146/rebuild

review: Approve (continuous-integration)
lp://staging/~josharenson/qtmir/disable_orientation_sensors_based_on_screen_state updated
274. By Josh Arenson

Change unityScreen to m_unityScreen as it is a member variable

Revision history for this message
Daniel d'Andrada (dandrader) wrote :

Looks good to me.

* Did you perform an exploratory manual test run of the code change and any related functionality?
Yes.

* Did CI run pass? If not, please explain why.
Yes.

review: Approve
Revision history for this message
Gerry Boland (gerboland) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches