Juju Charms Collection
juju-gui package

Code review comment for lp://staging/~jose/charms/precise/juju-gui/add-blank-defaults

  1. Precise Pangolin (12.04)
  2. add-blank-defaults
  3. Merge into trunk
Revision history for this message
Francesco Banconi (frankban) wrote :

Hi José,

thanks a lot for contributing to the GUI charm!
FWIW I think it should be easy enough to change utils.write_gui_config so that it handles login_help as an empty string if you prefer that strategy.

That said, the GUI charm development is done using the development branch in lp:~juju-gui/charms/trusty/juju-gui/trunk (see http://bazaar.launchpad.net/~juju-gui-charmers/charms/precise/juju-gui/trunk/view/head:/HACKING.md). When we create a new release, that branch is then pushed to the precise and trusty release branches (lp:charms/juju-gui and lp:charms/trusty/juju-gui).

Could you please re-propose your changes against that branch?
Also, please run "make lint" and "make unittest" before creating the MP.

Thanks!

« Back to merge proposal