Merge lp://staging/~joni-noplu/elisa/teletext_fix into lp://staging/elisa
Proposed by
Jonathan Rauprich
Status: | Merged |
---|---|
Merged at revision: | 1617 |
Proposed branch: | lp://staging/~joni-noplu/elisa/teletext_fix |
Merge into: | lp://staging/elisa |
Diff against target: |
21 lines (+10/-1) 1 file modified
elisa-plugins/elisa/plugins/poblesec/player_video.py (+10/-1) |
To merge this branch: | bzr merge lp://staging/~joni-noplu/elisa/teletext_fix |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Olivier Tilloy | Approve | ||
Review via email: mp+26430@code.staging.launchpad.net |
Description of the change
This fixes Bug #415031
To test it, u can download the attached file in the bug report. Instead of showing a popup to the user when a stream with teletext is played, only a debug message will be shown.
To post a comment you must log in.
Thanks for the patch!
I tested it and it behaves as expected.
I have a couple of minor cosmetic remarks on the patch itself, if you don't object I'll apply the following tweaks and merge:
- Typo: s/Gestreamer/ GStreamer/
- Typo: s/poping/popping/
- I'd like the comment to include a link to the bug report (bug #415031)
- The debug string contains extra spaces between "for" and "teletext"