Code review comment for lp://staging/~johnsca/charms/trusty/haproxy/xenial-support

Revision history for this message
James Jesudason (jamesj) wrote :

Thanks, that looks good.

I can't run tests locally at the moment as I'm on Juju 2.0. The two tests look as though they are very similar and could be refactored to call a function to remove the code duplication. I'll approve and merge for now and we can look at refactoring later.

review: Approve

« Back to merge proposal