Code review comment for lp://staging/~johannes.erdfelt/nova/lp844905
Revision history for this message
| Sandy Walsh (sandy-walsh) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
513534c
demo site
(Get the code!)
Finding it hard to see that the new code is being properly covered by the tests.
Ideally I'd like to see explicit unit tests on each of the new methods added (and ensuring they hit each of the conditional branches).
At the very least, some description in the unit tests as to what they are actually testing and which methods are being touched. But ideally, simple single-method unit tests.