Code review comment for lp://staging/~joetalbott/uci-engine/split_infra_failures

Good job !

I think that's the right approach (especially introducing progress_errored !).

I agree with Francis remarks overall.

I'll add that we don't want to introduce a coupling between amqp_worker and data_store so I'd rather override in the test runner which knows about data_store.

https://code.launchpad.net/~vila/uci-engine/nova-failure-as-testbed-exception/+merge/245831 is attempting to land right now and we now also want to catch TestBedException.

As Francis said, we don't want to list all possible exceptions in amqp_worker and TestBedException is definitely specific to the test runner only.