Merge into trunk : WebViewCrashHandling : Code : uNav

Status:	Needs review
Proposed branch:	lp://staging/~joergberroth/unav/WebViewCrashHandling
Merge into:	lp://staging/unav
Diff against target:	417 lines (+174/-35) 9 files modified qml/Favorites.qml (+2/-0) qml/Location.qml (+4/-0) qml/Main.qml (+32/-19) qml/PoiDetailsPage.qml (+2/-0) qml/PoiListPage.qml (+2/-0) qml/SearchPage.qml (+1/-3) qml/components/NotificationBar.qml (+30/-2) qml/components/POIQuickAccessGridView.qml (+9/-11) qml/components/WebProcessMonitor.qml (+92/-0)
To merge this branch:	bzr merge lp://staging/~joergberroth/unav/WebViewCrashHandling
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
costales		2016-06-06	Pending
Review via email: mp+296529@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-05-27.

Commit message

* added WebProcessMonitor.qml from webbrowser-app to manage webview kills
  - notification that map crashed.
  - try to reload webview if it was killed.
  - if a route was active, it will be reloaded again.
* adjusted NotificationBar.qml and some code clean up (NotificationBarTimer handling)

Description of the change

* added WebProcessMonitor.qml from webbrowser-app to manage webview kills
  - notification that map crashed.
  - try to reload webview if it was killed.
  - if a route was active, it will be reloaded again.
* adjusted NotificationBar.qml and some code clean up (NotificationBarTimer handling)

Revision history for this message

costales (costales) wrote on 2016-06-02: Posted in a previous version of this proposal

#

It didn't work for me.
I used uNav in the morning.
After ~10 hours, I opened and I saw the map and the red popup.
uNav was freezed ~5 seconds and then, the system killed it.

review: Needs Fixing

Revision history for this message

costales (costales) wrote on 2016-06-13:

#

Hi Joerg. I'm doing tests and this is working :))

Please, one question. Why this?

=== modified file 'nav/index.html'
--- nav/index.html 2016-06-08 17:14:51 +0000
+++ nav/index.html 2016-06-13 18:14:57 +0000
@@ -593,6 +593,7 @@
    nav.set_route_status('yes');
    ui.update();
    qml_set_center_onpos(2);
+ qml_set_route_status();
   }
  </script>

Thanks |o/

Reply

Revision history for this message

JkB (joergberroth) wrote on 2016-06-13:

#

Hey,
This line is needed to always set the current end coords on qml side.
This enables to set the last active route after an oxide crash again
automtically.

Am Montag, 13. Juni 2016 20:20:31 CEST schrieb costales
<email address hidden>:
> Hi Joerg. I'm doing tests and this is working :))
>
> Please, one question. Why this?
>
> === modified file 'nav/index.html'
> --- nav/index.html 2016-06-08 17:14:51 +0000
> +++ nav/index.html 2016-06-13 18:14:57 +0000
> @@ -593,6 +593,7 @@
> nav.set_route_status('yes');
> ui.update();
> qml_set_center_onpos(2);
> + qml_set_route_status();
> }
> </script>
>
> Thanks |o/

--
Versandt, mit Dekko von meinem Ubuntu-Gerät

Reply

Revision history for this message

costales (costales) wrote on 2016-06-13:

#

From my knowledge and tests more than 1 call between qml + html
created weird conflicts.

Could be that set in the initialization call on the new .qml?

Best regards!

Reply

Revision history for this message

JkB (joergberroth) wrote on 2016-06-13:

#

?
So far i have not experieced any issues with that.
It is important, that qml side is updated with the route details ad soon as
a route starts. Maybe you find a better place for the command....

Am Montag, 13. Juni 2016 21:57:23 CEST schrieb costales
<email address hidden>:
>>From my knowledge and tests more than 1 call between qml + html
> created weird conflicts.
>
> Could be that set in the initialization call on the new .qml?
>
> Best regards!
>

--
Versandt, mit Dekko von meinem Ubuntu-Gerät

Reply

lp://staging/~joergberroth/unav/WebViewCrashHandling updated on 2016-06-14

77. By JkB on 2016-06-14: *merge with costales branch
78. By JkB on 2016-06-14: * modified notification text

Unmerged revisions

78. By JkB on 2016-06-14: * modified notification text
77. By JkB on 2016-06-14: *merge with costales branch
76. By JkB on 2016-06-05: *changed error messages text
75. By JkB on 2016-06-03: *removed timer and improved popup handling
74. By JkB on 2016-06-03: *merge with trunk
73. By JkB on 2016-06-01: *removed typo in id
*added close() signal
72. By JkB on 2016-05-29: *ensure that endLat/endLng will always be set in Main.qml if route_state changes to "yes"
71. By JkB on 2016-05-29: *add another notification
*wait 500ms before recalculating route
*modified a notifiacation in WebProcessMonitor.qml
70. By JkB on 2016-05-27: * small format fix
69. By JkB on 2016-05-27: * added WebProcessMonitor.qml from webbrowser-app to manage webview kills
  - notification that map crashed.
  - try to reload webview if it was killed.
  - if a route was active, it will be reloaded again.
* adjusted NotificationBar.qml and some code clean up (NotificationBarTimer handling)

uNav

Merge lp://staging/~joergberroth/unav/WebViewCrashHandling into lp://staging/unav

Commit message

Description of the change

Unmerged revisions

Preview Diff

Subscribers