Merge lp://staging/~joergberroth/unav/WebViewCrashHandling into lp://staging/unav

Proposed by JkB
Status: Superseded
Proposed branch: lp://staging/~joergberroth/unav/WebViewCrashHandling
Merge into: lp://staging/unav
Diff against target: 321 lines (+156/-29)
5 files modified
nav/index.html (+1/-0)
qml/Main.qml (+24/-16)
qml/components/NotificationBar.qml (+30/-2)
qml/components/POIQuickAccessGridView.qml (+9/-11)
qml/components/WebProcessMonitor.qml (+92/-0)
To merge this branch: bzr merge lp://staging/~joergberroth/unav/WebViewCrashHandling
Reviewer Review Type Date Requested Status
costales Needs Fixing
Review via email: mp+295984@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2016-06-06.

Commit message

* added WebProcessMonitor.qml from webbrowser-app to manage webview kills
  - notification that map crashed.
  - try to reload webview if it was killed.
  - if a route was active, it will be reloaded again.
* adjusted NotificationBar.qml and some code clean up (NotificationBarTimer handling)

Description of the change

* added WebProcessMonitor.qml from webbrowser-app to manage webview kills
  - notification that map crashed.
  - try to reload webview if it was killed.
  - if a route was active, it will be reloaded again.
* adjusted NotificationBar.qml and some code clean up (NotificationBarTimer handling)

To post a comment you must log in.
70. By JkB

* small format fix

71. By JkB

*add another notification
*wait 500ms before recalculating route
*modified a notifiacation in WebProcessMonitor.qml

72. By JkB

*ensure that endLat/endLng will always be set in Main.qml if route_state changes to "yes"

Revision history for this message
costales (costales) wrote :

It didn't work for me.
I used uNav in the morning.
After ~10 hours, I opened and I saw the map and the red popup.
uNav was freezed ~5 seconds and then, the system killed it.

review: Needs Fixing
73. By JkB

*removed typo in id
*added close() signal

74. By JkB

*merge with trunk

75. By JkB

*removed timer and improved popup handling

76. By JkB

*changed error messages text

77. By JkB

*merge with costales branch

78. By JkB

* modified notification text

Unmerged revisions

78. By JkB

* modified notification text

77. By JkB

*merge with costales branch

76. By JkB

*changed error messages text

75. By JkB

*removed timer and improved popup handling

74. By JkB

*merge with trunk

73. By JkB

*removed typo in id
*added close() signal

72. By JkB

*ensure that endLat/endLng will always be set in Main.qml if route_state changes to "yes"

71. By JkB

*add another notification
*wait 500ms before recalculating route
*modified a notifiacation in WebProcessMonitor.qml

70. By JkB

* small format fix

69. By JkB

* added WebProcessMonitor.qml from webbrowser-app to manage webview kills
  - notification that map crashed.
  - try to reload webview if it was killed.
  - if a route was active, it will be reloaded again.
* adjusted NotificationBar.qml and some code clean up (NotificationBarTimer handling)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches