Code review comment for lp://staging/~jmarsden/ubiquity/lp775124

I thought there should be a better way, but I didn't get as far as figuring out what it was! Also, I was looking for a small quick fix, something that might be simple enough to validate that it could get accepted even though we are already in beta :) Sounds like you would prefer I "do it right"... OK.

I think you are saying that there should be a debconf variable ubiquity/minfreespace (or some such name), defined in the debian/templates file in the ubiquity package, and if that variable exists, then ubi-prepare.py would use that value as the offset to filesystem.size to compute the minimum disk space needed, rather than my 600MB hardcoded constant. Otherwise, default to filesystem.size*2 as now, strange though that *2 is.

That makes sense, but I'm not sure I know quite how to do that in Python, and I was looking for a small quick fix that might be simple enough to validate that it could get accepted during beta :)

I'll see what I can come up with using debconf. Oh... once I code this, how can I test it? Is there a way to edit a local copy of lubuntu.seed to include a line setting this new debconf variable, and then say "build me an ISO" using this seed, on my local machine? I understand the build process enough to know what a seed file does and how to edit it to set a debconf variable with a d-i line, but not enough to know how to cause an ISO build to happen locally using a local repository mirror. Pointers appreciated.

Thanks,

Jonathan