Daisy

Merge lp://staging/~jjo/daisy/implement-random_early_drop-write-policy into lp://staging/daisy

  1. implement-random_early_drop-write-policy
  2. Merge into trunk
Proposed by JuanJo Ciarlante
Status: Merged
Merged at revision: 267
Proposed branch: lp://staging/~jjo/daisy/implement-random_early_drop-write-policy
Merge into: lp://staging/daisy
Diff against target: 51 lines (+27/-0)
1 file modified
daisy/submit_core.py (+27/-0)
To merge this branch: bzr merge lp://staging/~jjo/daisy/implement-random_early_drop-write-policy
Reviewer Review Type Date Requested Status
Evan (community) Needs Fixing
Review via email: mp+153448@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Evan (ev) wrote :

This looks excellent. But I think returning True out of write_to_* when we haven't written is wrong. The oopsid:provider_name will get put on the queue with nothing to read off it on the retracer side.

review: Needs Fixing
Revision history for this message
JuanJo Ciarlante (jjo) wrote :

Just for completness: agreed with ev's comment, implemented so (with got approved+merged).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches