Or, better, s/cxt/context/ -- those few saved bytes/keystrokes really
aren't worth the mental load, especially for someone who's not already
familiar with that abbreviation.
(it took me a while to understand this myself, because ctx is such a
"natural" -- ie familiar -- contraction for me, but really: good
long(ish) variable names help everybody)
LGTM with typo fix. Bonus points for idying up the other var/method
names, but not mandatory -- just sort out "cxt" and I'll approve.
(fwiw you can fix the description with `lbox propose -edit`)
https:/ /codereview. appspot. com/98610044/ diff/110001/ cmd/juju/ addmachine_ test.go addmachine_ test.go (right):
File cmd/juju/
https:/ /codereview. appspot. com/98610044/ diff/110001/ cmd/juju/ addmachine_ test.go# newcode33 addmachine_ test.go: 33: cxt, err := runAddMachine(c)
cmd/juju/
s/cxt/ctx/ throughout.
Or, better, s/cxt/context/ -- those few saved bytes/keystrokes really
aren't worth the mental load, especially for someone who's not already
familiar with that abbreviation.
(it took me a while to understand this myself, because ctx is such a
"natural" -- ie familiar -- contraction for me, but really: good
long(ish) variable names help everybody)
https:/ /codereview. appspot. com/98610044/ diff/110001/ cmd/juju/ addmachine_ test.go# newcode87 addmachine_ test.go: 87: s._assertAddCon tainer( c,
cmd/juju/
strconv.Itoa(i), machine, ctype)
this "_assert" is weird. Don't suppose anyone knows why we did that?
https:/ /codereview. appspot. com/98610044/