> [2] sorry, just noticed:
>
> get_ip_address_for_unit and get_ip_address_for_machine appear to be duplicated
> in control.ssh and control.scp; we shoudl probably fix that :).
Good catch, this can be simply refactored by consolidating these functions into juju.control.utils.
>
> Other than that, still approve; sorry I missed this.
> [2] sorry, just noticed: address_ for_unit and get_ip_ address_ for_machine appear to be duplicated
>
> get_ip_
> in control.ssh and control.scp; we shoudl probably fix that :).
Good catch, this can be simply refactored by consolidating these functions into juju.control.utils.
>
> Other than that, still approve; sorry I missed this.
Good to know! Thanks for the second look.