Code review comment for lp://staging/~jimbaker/pyjuju/scp-command

Revision history for this message
Jim Baker (jimbaker) wrote :

> [2] sorry, just noticed:
>
> get_ip_address_for_unit and get_ip_address_for_machine appear to be duplicated
> in control.ssh and control.scp; we shoudl probably fix that :).

Good catch, this can be simply refactored by consolidating these functions into juju.control.utils.

>
> Other than that, still approve; sorry I missed this.

Good to know! Thanks for the second look.

« Back to merge proposal