Code review comment for lp://staging/~jimbaker/pyjuju/relation-info-command-spec

Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

https://codereview.appspot.com/5837050/diff/3001/source/drafts/relation-info.rst
File source/drafts/relation-info.rst (right):

https://codereview.appspot.com/5837050/diff/3001/source/drafts/relation-info.rst#newcode7
source/drafts/relation-info.rst:7: relation-info [--interface INTERFACE]
[-r RELATION_NAME_OR_ID]
If this command enumerates relation ids, how can it accept a relation id
as a parameter? Also, I don't see how it can take a service name as a
parameter either, or why it takes an interface, or even a unit name.

If I understand what this command is doing, I'd imagine something much
simpler instead:

     relation-ids [<relation name>]

This will list the given relation name, or the relation name currently
executing if the parameter is omitted.

If you have real problems that need a more complex interface than this,
can you please ping me online? I'd be happy to understand them.

https://codereview.appspot.com/5837050/diff/3001/source/drafts/relation-info.rst#newcode21
source/drafts/relation-info.rst:21: possible to filter that as desired
without using the `--interface`
So why do we need it?

https://codereview.appspot.com/5837050/diff/3001/source/drafts/relation-info.rst#newcode25
source/drafts/relation-info.rst:25: verify the continued existence of
this relation id for the
That's relation-ids | grep $R

https://codereview.appspot.com/5837050/diff/3001/source/drafts/relation-info.rst#newcode31
source/drafts/relation-info.rst:31: script. Calling `relation-info` for
other services is read at that
Why do we need to ask about relation ids for other services? Nothing in
juju allows the local unit to fiddle with relation names and ids from
remote services or units.

https://codereview.appspot.com/5837050/

« Back to merge proposal