Code review comment for lp://staging/~jimbaker/pyjuju/relation-hook-commands-spec

Revision history for this message
Jim Baker (jimbaker) wrote :

Please take a look.

https://codereview.appspot.com/5836050/diff/6001/source/drafts/relation-hook-commands.rst
File source/drafts/relation-hook-commands.rst (right):

https://codereview.appspot.com/5836050/diff/6001/source/drafts/relation-hook-commands.rst#newcode22
source/drafts/relation-hook-commands.rst:22: ``db:42``, as obtained by
using the `relation-info` command,
On 2012/03/27 13:00:55, hazmat wrote:
> should read relation-ids

Done.

https://codereview.appspot.com/5836050/diff/6001/source/drafts/relation-hook-commands.rst#newcode47
source/drafts/relation-hook-commands.rst:47: error is raised stating
"Relation not found".
Because both relation-ids for all relation names for the local service
and the corresponding contexts are now cached prior to invocation of the
hook, it is not possible for such a blow up to occur: there will be
consistency between them.

https://codereview.appspot.com/5836050/diff/6001/source/drafts/relation-hook-commands.rst#newcode56
source/drafts/relation-hook-commands.rst:56: that such nodes are not
garbage-collected from ZooKeeper, even if
Fair enough, I have removed this implementation note.

https://codereview.appspot.com/5836050/

« Back to merge proposal