https://codereview.appspot.com/5836050/diff/2001/source/drafts/relation-hook-commands.rst#newcode70
source/drafts/relation-hook-commands.rst:70: * If a relation name is
specified with `-r` and the relation cannot
This sounds very error prone. Having a command that seems to work with
one relation established but breaks with two will yield charms that seem
to work but break in the wild. Can we please support relation ids only
for the moment?
https:/ /codereview. appspot. com/5836050/ diff/2001/ source/ drafts/ relation- hook-commands. rst drafts/ relation- hook-commands. rst (right):
File source/
https:/ /codereview. appspot. com/5836050/ diff/2001/ source/ drafts/ relation- hook-commands. rst#newcode1 drafts/ relation- hook-commands. rst:1: Commands to work with
source/
relation settings and membership
Isn't this spec simply adding a -r option to relation?
https:/ /codereview. appspot. com/5836050/ diff/2001/ source/ drafts/ relation- hook-commands. rst#newcode2 drafts/ relation- hook-commands. rst:2: ------- ------- ------- ------- ------- ------- -----
source/
-------
Please fix the header formats.
https:/ /codereview. appspot. com/5836050/ diff/2001/ source/ drafts/ relation- hook-commands. rst#newcode45 drafts/ relation- hook-commands. rst:45: name ``server``. There may relations/
source/
be multiple such established relalation to
s/relalation/
https:/ /codereview. appspot. com/5836050/ diff/2001/ source/ drafts/ relation- hook-commands. rst#newcode70 drafts/ relation- hook-commands. rst:70: * If a relation name is
source/
specified with `-r` and the relation cannot
This sounds very error prone. Having a command that seems to work with
one relation established but breaks with two will yield charms that seem
to work but break in the wild. Can we please support relation ids only
for the moment?
https:/ /codereview. appspot. com/5836050/ diff/2001/ source/ drafts/ relation- hook-commands. rst#newcode79 drafts/ relation- hook-commands. rst:79: when first originally
source/
instantiated. In between this write and the
Why is the ordering important? Can't we leave that as an implementation
detail?
https:/ /codereview. appspot. com/5836050/