Code review comment for lp://staging/~jeremywootten/pantheon-files/restore-state

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Thanks Cody, I'll fix those errors. The reason it started in /home at
first is because that is the default setting in the schema (you cannot have
a variable in the schema). However, it should be possible to fix that as
well.

On 3 May 2014 23:25, Cody Garver <email address hidden> wrote:

> Review: Needs Fixing
>
> The first time I ran this, it opened in /home instead of /home/$USER for
> some reason
>
> 175,198: looks like superfluous blank lines may have made it in
>
> 230: end of comment needs a space
>
> 454: code style
>
> 844-845: comment style
>
> 869, 871: code style
>
> 906: code style
>
> 916: does this need a blank line after? stacked comments look weird
>
> 923: unrelated commented out code
>
> 945, 951: code style
>
> 970: commented out code
> --
>
> https://code.launchpad.net/~jeremywootten/pantheon-files/restore-state/+merge/217733
> You are the owner of lp:~jeremywootten/pantheon-files/restore-state.
>

« Back to merge proposal