Code review comment for lp://staging/~jeremywootten/pantheon-files/refactor-location-bar-part2

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

xapantu: Thanks for the review. I think most of the changes to the CMakeList.txt files were required to make the branch compile although e.g. r1974 and r1975 may not be strictly essential for this branch. Which changes are you disapproving?

I have split the intended changes into three parts already (see parts 1 and 3 also proposed), but this part is not so easy to split, while maintaining buildability and full functionality, as most of the changes are interdependent. Do you have any advice as to how this branch may be further split?

I'll remake the branch using bzr mv as suggested.

« Back to merge proposal