Code review comment for lp://staging/~jelmer/bzr/hpss-_get-checkout-format

On 11/29/2011 08:28 PM, Martin Pool wrote:
> Does this actually make sense to ask across the network? Is this
> something we could instead either get at the time the Branch is
> opened, or just know from local data about the branch format?
The checkout format can be different from that of the source branch in
some cases. We already have a BzrDir.cloning_metadir() HPSS method,
which behaves similarly, but is used for clone-oriented-operations (vs
checkout operations).

BzrBranch4 uses a metadir-based checkout format while it itself isn't
metadir-based, and SVN has a different checkout dir format than its
storage dir format. These probably aren't very relevant in practice, though.

Perhaps the HPSS call should be for BzrDir.checkout_metadir() rather
than Branch._get_checkout_format() though?

Cheers,

Jelmer