bzr-builder

Merge lp://staging/~jelmer/bzr-builder/lp-urls into lp://staging/bzr-builder

lp-urls
Merge into trunk

Proposed by Jelmer Vernooij on 2011-05-18

Status:

Merged

Approved by:

James Westby on 2011-05-18

Approved revision:

128

Merged at revision:

126

Proposed branch:

lp://staging/~jelmer/bzr-builder/lp-urls

Merge into:

lp://staging/bzr-builder

Diff against target:

342 lines (+108/-63)

3 files modified

cmds.py (+105/-52)
ppa.py (+2/-10)
tests/test_blackbox.py (+1/-1)

To merge this branch:

bzr merge lp://staging/~jelmer/bzr-builder/lp-urls

Low

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
James Westby		2011-05-18	Approve on 2011-05-18
Review via email: mp+61446@code.staging.launchpad.net

Description of the change

Support building directly from a Launchpad recipe URL.

This means that things like:

bzr dailydeb https://code.launchpad.net/~bzr/+recipe/bzr-stats-daily

now do the right thing

Revision history for this message

James Westby (james-w) wrote on 2011-05-18:

78 + if safe:
79 + permitted_instructions = SAFE_INSTRUCTIONS
80 + else:
81 + permitted_instructions = None

Would you move that above the opening of the file, so that it is outside
of the try block, so that block is clearly focused on the code that
might reasonably fail?

Thanks for the cool feature.

James

review: Approve

Revision history for this message

Jelmer Vernooij (jelmer) wrote on 2011-05-18:

On Wed, 2011-05-18 at 18:14 +0000, James Westby wrote:
> Review: Approve
> 78 + if safe:
> 79 + permitted_instructions = SAFE_INSTRUCTIONS
> 80 + else:
> 81 + permitted_instructions = None
>
> Would you move that above the opening of the file, so that it is outside
> of the try block, so that block is clearly focused on the code that
> might reasonably fail?
Done.

> Thanks for the cool feature.
Thanks!

Cheers,

Jelmer