Code review comment for lp://staging/~jelmer/bzr-builder/lp-urls

Revision history for this message
James Westby (james-w) wrote :

78 + if safe:
79 + permitted_instructions = SAFE_INSTRUCTIONS
80 + else:
81 + permitted_instructions = None

Would you move that above the opening of the file, so that it is outside
of the try block, so that block is clearly focused on the code that
might reasonably fail?

Thanks for the cool feature.

James

review: Approve

« Back to merge proposal