Code review comment for lp://staging/~jelmer/bzr-builddeb/get-source-format

Revision history for this message
James Westby (james-w) wrote :

On Fri, 15 Jul 2011 14:20:03 -0000, Jelmer Vernooij <email address hidden> wrote:
> if not tree.has_filename("debian/source/format"):
> return FORMAT_1_0
> - return tree.get_file_text(tree.path2id("debian/source/format")).strip()
> + text = tree.get_file_text(tree.path2id("debian/source/format"),
> + "debian/source/format")
> + return text.strip()

Looks good, but perhaps we could make all those magic strings one
variable?

Thanks,

James

« Back to merge proposal