Code review comment for lp://staging/~jelmer/brz/fix-flaky

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

This test has always been broken. We can either:

1) Remove the test altogether
2) Make the test just raise KnownFailure
3) The current solution

I don't have particularly strong opinion on what we do here, but we should somehow get rid of this error.

The current approach at least means we find out about the regression that the test checks for, even if we sometimes effectively don't run the test. We take a similar approach on line 195

« Back to merge proposal