Code review comment for lp://staging/~jdstrand/webapps-core/lp1296170

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

> I just didn't want '*' in there and they seem to be using one letter
> hostnames, so I went with that. Note this:
> [a-z][a-z0-9]+
>
> requires at least a two-character hostname and would not resolve the issue for
> me.

right,

>
> I forgot about the translation of 'https?://*.facebook.com/*' to
> 'https?://[^\\./]*.facebook.com/*'. I would be fine with:
> 'https?://*.facebook.com/*'. Should I resubmit?

I'd say yes, just to avoid too much heterogeneous approaches when we can,

« Back to merge proposal