Code review comment for lp://staging/~jdstrand/webapps-core/lp1296170

Revision history for this message
Alexandre Abreu (abreu-alexandre) wrote :

Is there a specific reason why you have something like [a-z]+ and not e.g. [a-z][a-z0-9]+ ?

Also, the url patterns specified at this level (specified in --webappUrlPatterns) are actually a weak versions of wildcard patterns (with '?' as an extra pattern char). So full blown regexp should not really used (although not strictly forbidden). In this context maybe 'https?://*.facebook.com/*' would match your needs a bit more (it'll be translated to 'https?://[^\\./]*.facebook.com/*' ?

review: Needs Information

« Back to merge proposal