Code review comment for lp://staging/~jb.eficent/department-mgmt/department-mgmt-bugfix-1296055

Revision history for this message
JB (eficent.com) (jb.eficent) wrote :

Thanks Pedro,

The existing module as it is now drives the department from the section. Perhaps, as you suggest, it should derive it only from the employee, as it is done in other objects in this same project.

The bug found to the existing code refers to the fact that changing the employee in the lead will change the section, and will not refresh the department if the new section lead to a different one.

So, if you agree I will completely remove the department determination from the section, and use instead the determination from employee.

« Back to merge proposal