Code review comment for lp://staging/~james-w/pkgme/further-test-fixes

On Mon, 24 Jan 2011 19:28:31 -0000, Barry Warsaw <email address hidden> wrote:
> > + try:
> > + proc = subprocess.Popen(
> > + [script_path], stdout=subprocess.PIPE,
> > + stderr=subprocess.STDOUT, stdin=subprocess.PIPE,
> > + cwd=path)
> > + except OSError, e:
>
> Probably should use "except OSError as e" for forward compatibility. (We only
> have to support >=Python 2.6, right?)

I guess so. Someone is bound to request 2.3 support some day, but I'm
fine with 2.6 for now.

Thanks,

James