Code review comment for lp://staging/~james-w/launchpad-work-items-tracker/multi-project

Revision history for this message
James Westby (james-w) wrote :

> Right, that's the auto-reset code. BTW, this is not just an issue for
> resetting the charts, the more important usage is that you need to determine
> what the "next" milestone is. Ubuntu alpha-2 needs to go until the day Ubuntu
> alpha-3 starts, not until an intermediate milestone of a different project
> source.

I hadn't understood what the milestone charts were doing before. Thanks for the pointer.

> The svgs are already skipped if they are empty, and empty HTML pages don't
> cost that much to generate. Of course this won't be a combinatorial explosion,
> that was a thinko, sorry. It's just additive, so no big deal.

Ok. I'm going to see if I can come up with a cunning way to avoid some of
this without configuration.

> So the main points to consider here are the merging of the milestone table
> (which is just a small implementation problem),

I've pushed up a small change that does this, but may alter the approach depending
on the solution to the next issue.

> and making milestones "source"
> specific, so that the individual charts can still know how long a milestone
> is, and when to reset it.

I've just chatted to Jamie, and this doesn't go quite as far as we would like
in Linaro, where we would like to have consolidated burndown charts for milestones
where the Ubuntu and Linaro milestones are on the same date. I will aim to have
no change for Ubuntu teams when doing this though.

Thanks,

James

« Back to merge proposal