Juju Charms Collection
keystone package

Code review comment for lp://staging/~james-page/charms/trusty/keystone/network-splits

  1. Trusty Tahr (14.04)
  2. network-splits
  3. Merge into next
Revision history for this message
Liam Young (gnuoy) wrote :

Unit test and lint failures:

test_add_service_to_keystone_clustered_https_none_values (unit_tests.test_keystone_utils.TestKeystoneUtils) ... ERROR
test_add_service_to_keystone_no_clustered_no_https_complete_values (unit_tests.test_keystone_utils.TestKeystoneUtils) ... ERROR
test_add_service_to_keystone_nosubset (unit_tests.test_keystone_utils.TestKeystoneUtils) ... ERROR

hooks/keystone_hooks.py:204:1: W293 blank line contains whitespace
hooks/keystone_utils.py:19:1: F401 'get_address_in_network' imported but unused
hooks/keystone_utils.py:40:1: F401 'unit_private_ip' imported but unused

review: Needs Fixing

« Back to merge proposal