Code review comment for lp://staging/~jameinel/subunit/omit-times-623654

Revision history for this message
Jonathan Lange (jml) wrote :

I've been working on this branch, trying to make the tests a bit clearer and making sure that the behaviour is "correct" as Rob determines it (although I still hold to my point that two consecutive time: statements are meaningless).

Anyway, I came across bug 716554, which means that my comment dated 2010-10-19 isn't entirely appropriate -- this branch just keeps up an existing bug.

Personally, I would rather fix the bug first, then land this branch (or my version with clearer tests, lp:~jml/subunit/omit-times-623654). I don't think the order matters too much though.

« Back to merge proposal