Code review comment for lp://staging/~jameinel/juju-core/timing-test

Revision history for this message
John A Meinel (jameinel) wrote :

https://codereview.appspot.com/10234047/diff/1/cmd/juju/plugin_test.go
File cmd/juju/plugin_test.go (right):

https://codereview.appspot.com/10234047/diff/1/cmd/juju/plugin_test.go#newcode96
cmd/juju/plugin_test.go:96: // Thus if we don't start them in parallel,
we would deadlock
On 2013/06/13 10:53:48, gz wrote:
> I didn't understand this comment till I went back and read the mp
description
> properly. But now it seems obvious, so can't think of clarifications.

> Maybe:

> // Make plugins with dependencies that will deadlock unless started in
parallel

Updated.

https://codereview.appspot.com/10234047/

« Back to merge proposal