Code review comment for lp://staging/~jameinel/juju-core/timing-test

Revision history for this message
Martin Packman (gz) wrote :

LGTM

https://codereview.appspot.com/10234047/diff/1/cmd/juju/plugin_test.go
File cmd/juju/plugin_test.go (left):

https://codereview.appspot.com/10234047/diff/1/cmd/juju/plugin_test.go#oldcode99
cmd/juju/plugin_test.go:99: suite.makeFullPlugin(PluginParams{Name:
"slow", Sleep: 200 * time.Millisecond})
Yeay for losing sleeps.

https://codereview.appspot.com/10234047/diff/1/cmd/juju/plugin_test.go
File cmd/juju/plugin_test.go (right):

https://codereview.appspot.com/10234047/diff/1/cmd/juju/plugin_test.go#newcode96
cmd/juju/plugin_test.go:96: // Thus if we don't start them in parallel,
we would deadlock
I didn't understand this comment till I went back and read the mp
description properly. But now it seems obvious, so can't think of
clarifications.

Maybe:

// Make plugins with dependencies that will deadlock unless started in
parallel

https://codereview.appspot.com/10234047/

« Back to merge proposal