lp://staging/~jameinel/juju-core/reflect-registry
- Get this branch:
- bzr branch lp://staging/~jameinel/juju-core/reflect-registry
Branch merges
Related source package recipes
Branch information
Recent revisions
- 2727. By John A Meinel
-
Unwrapping more layers starts to look good.
I'm slowly unteasing what we actually want for rpc.Serve.
Rather than wanting an object and using rpcreflect.Value, what we really
just want is something that implements MethodCaller and possibly Kill.
This should make it easily possible for an external implementation to
provide a custom way of mapping requests (alternative Registry, etc.) - 2726. By John A Meinel
-
Move the code into its own dir, since it isn't really related to rpcreflect anymore.
We use a couple of the functions, and some of MethodCaller is private that we want to
set, so we exposed it as a public function instead of a private one.
Arguably CallNotImplementedError should be in 'common' and shared into
both of them.
MethodCaller as a type could be just shared, but MethodCallerFromValue uses ObjTypeOf, and
thus does depend on 'rpcreflect'. (so rpcreflect couldn't import it from somewhere else, as
it has to call back into rpcreflect.) - 2724. By John A Meinel
-
Switch to returning all known versions.
The returned slice is sorted, so if we wanted just Min and Max, you can always
use [0] and [len(slice)-1] to get the min and max.
It also is easy with a sorted slice to check if there are any gaps.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/~go-bot/juju-core/trunk
