Merge lp://staging/~jameinel/goose/user-agent into lp://staging/goose
| Status: | Merged |
|---|---|
| Approved by: | John A Meinel |
| Approved revision: | 70 |
| Merged at revision: | 67 |
| Proposed branch: | lp://staging/~jameinel/goose/user-agent |
| Merge into: | lp://staging/goose |
| Diff against target: |
216 lines (+134/-22) 4 files modified
http/client.go (+24/-22) http/client_test.go (+73/-0) version.go (+23/-0) version_test.go (+14/-0) |
| To merge this branch: | bzr merge lp://staging/~jameinel/goose/user-agent |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Dimiter Naydenov (community) | Approve | ||
|
Review via email:
|
|||
Commit message
http/client.
This changes the User-Agent supplied by goose from being a generic "Go http package" to stating it is goose and what version.
Along with that change, it adds a goose.Version to the package, and goose.VersionNu
I didn't try to do the complex work that juju-core/
Description of the change
http/client.
This changes the User-Agent supplied by goose from being a generic "Go http package" to stating it is goose and what version.
Along with that change, it adds a goose.Version to the package, and goose.VersionNu
I didn't try to do the complex work that juju-core/
Thinking about it, would we want a way for juju-core to register its version as well and report it in the user-agent? It might be more useful than just the goose client library version.
Looks good and I like it how it simplifies a few things in headers generation.