Code review comment for lp://staging/~jameinel/goose/security-group-rule-group-id-1226996

The attempt to merge lp:~jameinel/goose/security-group-rule-group-id-1226996 into lp:goose failed. Below is the output from the failed tests.

ok launchpad.net/goose 0.011s
ok launchpad.net/goose/client 0.107s
ok launchpad.net/goose/errors 0.011s
ok launchpad.net/goose/glance 0.022s
ok launchpad.net/goose/http 0.060s
ok launchpad.net/goose/identity 0.029s
ok launchpad.net/goose/nova 0.104s
ok launchpad.net/goose/swift 0.057s
ok launchpad.net/goose/sync 0.010s
ok launchpad.net/goose/testing/envsuite 0.019s
ok launchpad.net/goose/testing/httpsuite 0.068s
? launchpad.net/goose/testservices [no test files]
? launchpad.net/goose/testservices/cmd [no test files]
ok launchpad.net/goose/testservices/hook 0.011s
ok launchpad.net/goose/testservices/identityservice 0.025s
total: 58

----------------------------------------------------------------------
PANIC: service_test.go:642: NovaSuite.TestAddHasRemoveSecurityGroupRule

... Panic: Neither Cidr nor GroupId are set for this SecurityGroup Rule: { 0 0 <nil> 1} (PC=0x413B51)

/usr/lib/go/src/pkg/runtime/panic.c:229
  in panic
service.go:477
  in Nova.addSecurityGroupRule
service_test.go:651
  in NovaSuite.TestAddHasRemoveSecurityGroupRule

----------------------------------------------------------------------
FAIL: service_test.go:862: NovaSuite.TestAddHasRemoveServerSecurityGroup

service_test.go:866:
    s.ensureNoGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:546: NovaSuite.TestAddRemoveSecurityGroup

service_test.go:548:
    s.createGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:816: NovaSuite.TestAddSecurityGroupRuleKeepsNegativePort

service_test.go:822:
    s.createGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:752: NovaSuite.TestAddSecurityGroupRuleToParentTwiceFails

service_test.go:759:
    s.createGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:738: NovaSuite.TestAddSecurityGroupRuleTwiceFails

service_test.go:740:
    s.createGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:792: NovaSuite.TestAddSecurityGroupRuleUpdatesParent

service_test.go:798:
    s.createGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:767: NovaSuite.TestAddSecurityGroupRuleWithInvalidParentFails

service_test.go:769:
    s.ensureNoGroup(c, invalidGroup)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:568: NovaSuite.TestAddSecurityGroupTwiceFails

service_test.go:570:
    s.createGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:552: NovaSuite.TestAddSecurityGroupWithRules

service_test.go:562:
    s.createGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:907: NovaSuite.TestAddServerSecurityGroupTwiceFails

service_test.go:912:
    s.createGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:897: NovaSuite.TestAddServerSecurityGroupWithInvalidGroupFails

service_test.go:900:
    s.ensureNoGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:887: NovaSuite.TestAddServerSecurityGroupWithInvalidServerFails

service_test.go:891:
    s.createGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:584: NovaSuite.TestAllSecurityGroups

service_test.go:587:
    // There is always a default security group.
    c.Assert(groups, HasLen, 1)
... obtained []nova.SecurityGroup = []nova.SecurityGroup{nova.SecurityGroup{Rules:[]nova.SecurityGroupRule{}, TenantId:"tenant", Id:"999", Name:"default", Description:"default group"}, nova.SecurityGroup{Rules:[]nova.SecurityGroupRule{}, TenantId:"tenant", Id:"1", Name:"", Description:""}}
... n int = 1

----------------------------------------------------------------------
FAIL: service_test.go:922: NovaSuite.TestAllServerSecurityGroups

service_test.go:943:
    s.createGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:625: NovaSuite.TestGetSecurityGroupByName

service_test.go:632:
    s.ensureNoGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:848: NovaSuite.TestRemoveSecurityGroupRuleTwiceFails

service_test.go:850:
    s.createGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:576: NovaSuite.TestRemoveSecurityGroupTwiceFails

service_test.go:578:
    s.createGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:991: NovaSuite.TestRemoveServerSecurityGroupTwiceFails

service_test.go:996:
    s.createGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:974: NovaSuite.TestRemoveServerSecurityGroupWithInvalidGroupFails

service_test.go:977:
    s.createGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

----------------------------------------------------------------------
FAIL: service_test.go:957: NovaSuite.TestRemoveServerSecurityGroupWithInvalidServerFails

service_test.go:961:
    s.createGroup(c, group)
service_test.go:40:
    c.Assert(err, ErrorMatches, fmt.Sprintf("no such security group %s", group.Id))
... value = nil
... regex string = "no such security group 1"
... Error value is nil

OOPS: 66 passed, 20 FAILED, 1 PANICKED
--- FAIL: Test (0.31 seconds)
FAIL
FAIL launchpad.net/goose/testservices/novaservice 0.340s
? launchpad.net/goose/testservices/openstackservice [no test files]
ok launchpad.net/goose/testservices/swiftservice 0.038s
ok launchpad.net/goose/tools/secgroup-delete-all 0.035s

Setting GOPATH to: /home/tarmac/trees
Running: go fmt ./...
Running: go build ./...
Running: go test ./...
FAIL: failed running: go test ./...