lp://staging/~jameinel/bzr/test-traceback-767177

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/bzr

Martin Pool: Needs Fixing on 2011-04-21

Martin Packman (community): Abstain on 2011-04-21

Jelmer Vernooij (community): Approve on 2011-04-20

Diff: 227 lines (+71/-44)

7 files modified

bzr (+2/-2)
bzrlib/tests/per_transport.py (+13/-4)
bzrlib/transport/__init__.py (+34/-31)
bzrlib/transport/sftp.py (+2/-5)
doc/en/release-notes/bzr-2.4.txt (+9/-0)
doc/en/whats-new/whats-new-in-2.4.txt (+9/-0)
setup.py (+2/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #656170: EBADF in paramiko during parallel selftest	High	Fix Released
Bug #767177: Thread traceback running test suite on Maverick	Medium	In Progress

Link a bug report

Related blueprints

5811. By John A Meinel on 2011-04-22

Update setup.py and release-notes to say python 2.6

5810. By John A Meinel on 2011-04-21

Bug #767177 is a dupe of bug #656170, so update the numbers accordingly.

5809. By John A Meinel on 2011-04-21

Martin rightly pointed out that we needed more work done to drop 2.4 compatibility.

5808. By John A Meinel on 2011-04-20

Fix bug #767177. Be more agressive with file.close() calls.

Our test suite gets a number of thread leaks and failures because it happens to get async
SFTPFile.close() calls. (if an SFTPFile closes due to __del__ it is done as an async request,
while if you call SFTPFile.close() it is done as a synchronous request.)
We have a couple other cases, probably. Namely SFTPTransport.get() also does an async
prefetch of the content, so if you don't .read() you'll also leak threads that think they
are doing work that you want.

The biggest change here, though, is using a try/finally in a generator, which is not
python2.4 compatible.

5807. By Canonical.com Patch Queue Manager <email address hidden> on 2011-04-20

(jelmer) Move more tests that require the full versioned file API from
 bt.per_repository to bt.per_repository_vf. (Jelmer Vernooij)

5806. By Canonical.com Patch Queue Manager <email address hidden> on 2011-04-20

(jelmer) Split Inventory._get_mutable_inventory() out into
 mutable_inventory_from_tree. (Jelmer Vernooij)

5805. By Canonical.com Patch Queue Manager <email address hidden> on 2011-04-19

(jelmer) Raise InvalidRevisionId when None is specified to
 Branch.set_last_revision_info(). (Jelmer Vernooij)

5804. By Canonical.com Patch Queue Manager <email address hidden> on 2011-04-19

(Jelmer) Make TestamentTree use a Tree rather than an Inventory.
 (Jelmer Vernooij)

5803. By Canonical.com Patch Queue Manager <email address hidden> on 2011-04-19

(jelmer) Add RevisionTree.get_file_revision,
 replacing an existing static method on Tree.
 This should also make it unnecessary to access the inventory in a couple
 more cases. (Jelmer Vernooij)

5802. By Canonical.com Patch Queue Manager <email address hidden> on 2011-04-19

(mbp) Deprecate 'bzr clone' and 'bzr get' (bug 506265) (Martin Pool)