Code review comment for lp://staging/~jameinel/bzr/2.4-client-reconnect-819604

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-05-24 8:36, Richard Wilbur wrote:
> Review: Approve
>
> This looks like a measured response to failures caused by network
> misbehaviour. It seems like a good idea to get these into a
> version that can be tested and then tweak them further, if needed,
> based on experience. +1
>

These changes have actually been in trunk for a long time. This is
just backporting it to earlier versions so that they also are in old
stable releases. (Launchpad itself will start disconnecting clients if
they are idle for too long, so we wanted people to not get too many
disconnects. Obviously releasing took longer than originally planned.)

So the changes should be pretty safe to land, since we've been
actively using them for >1year now.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlGgoN4ACgkQJdeBCYSNAAOH1QCgrc8wfn2yS+PbJxsdU4Ulslho
O08AoM0xE0NNaNinOSUsNX+5++mCfNkQ
=VCVm
-----END PGP SIGNATURE-----

« Back to merge proposal