Code review comment for lp://staging/~ivaldi/midori/midori-database-get-os

Revision history for this message
Cris Dywan (kalikiana) wrote :

I feel this bleeds too much logic which will have to be adjusted in all occurences if other os values or extensions come up. Either we need to eliminate the need for the extension or we should have function of the sort expand_filename(foo) that contains the logic.

review: Needs Fixing

« Back to merge proposal