Code review comment for lp://staging/~invitu/ocb-addons/6.1-fix-1193220

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Thanks, the merging went really well!

Unfortunately, the OPW code is not very nice.

l.39..43 this is begging for the use of setdefault
l.36 reuse of variable 'partners', now a list of browse records instead of ids
l.68..72 Looks very suspicious to me. Can this perhaps be replaced by

    filename = _('Followup-%s.%s') % (partner.name, frmt)
    attach = {filename: datax}

Your code has an error too, I suspect:
l.54 should be "tools.config.options.get", not "tools.config.get"

review: Needs Fixing

« Back to merge proposal