Code review comment for lp://staging/~intrigeri/apparmor/add-firefox-esr-to-ubuntu-browsers

Hi,

Steve Beattie wrote (23 Jun 2016 21:34:46 GMT):
> The problem with this is that firefox*{,.sh} is equivalent to firefox*.

Right (and since Christian noted this I've already changed the line to
firefox*).

> Furthermore it matches the firefox binary /usr/lib/firefox/firefox as
> shipped in ubuntu, which the original pattern did not.

> But (and this is what prevented me from replying when the original merge
> request was proposed), I'm not sure what the implications of that change
> are, if any. The shipped firefox profile in ubuntu (16.04 LTS at least)
> has "/usr/lib/firefox/firefox{,*[^s][^h]}" as it's profile match, so
> potentially this could cause interference.

OK. Let's avoid diving into this, if possible.

> Is there a more tightly bound pattern for the esr firefoxes that debian
> is shipping?

Yes, done in my updated branch :)