Code review comment for lp://staging/~intellectronica/launchpad/cve-templates-bug-423061

Revision history for this message
Michael Nelson (michael.nelson) wrote :

Hi Tom,

So we chatted about replacing the manual links that you've added with standard breadcrumbs on:

https://launchpad.dev/bugs/cve/+all (link: Search CVEs)
https://launchpad.dev/bugs/cve/2005-2737 and (link: Launchpad CVE tracker)

It's up to you - I think it would be good to do, but you said that these pages are very un-important and not worth the extra time investment - your call.

I would recommend completely removing the "CVE-2005-2737 details" portlet at:
https://launchpad.dev/bugs/cve/2005-2737

AIUI, object details should never be in the side-bar, and there's only one piece of info there which is not already in the main content - the link to the details at cve.mitre.org. I think you should just move that link into the main content.

With that removed, ui=me.

<noodles775> intellectronica: I'm just looking at your branch now. You've added some manual links on a few of the pages that seem like they could really be part of normal breadcrumbs... what's the reason for not using standard breadcrumbs?
<intellectronica> noodles775: that's just the way they were before, so i didn't consider the option. i suppose it's not a bad idea, but i also don't want to invest much more time in these templates, since they are not very important

review: Approve (ui)

« Back to merge proposal