Merge lp://staging/~hyuchia/pantheon-files/fix-1124209 into lp://staging/~elementary-apps/pantheon-files/trunk
Proposed by
Diego Islas Ocampo
Status: | Rejected |
---|---|
Rejected by: | Danielle Foré |
Proposed branch: | lp://staging/~hyuchia/pantheon-files/fix-1124209 |
Merge into: | lp://staging/~elementary-apps/pantheon-files/trunk |
Diff against target: |
373 lines (+154/-124) 4 files modified
src/CMakeLists.txt (+2/-2) src/Dialogs/PropertiesWindow.vala (+65/-46) src/View/Widgets/PermissionButton.vala (+0/-76) src/View/Widgets/PermissionComboBox.vala (+87/-0) |
To merge this branch: | bzr merge lp://staging/~hyuchia/pantheon-files/fix-1124209 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeremy Wootten | code | Approve | |
elementary UX | ui | Pending | |
Review via email: mp+318296@code.staging.launchpad.net |
Description of the change
Modified the Permissions Labels for directories while keeping the previous ones for files.
To post a comment you must log in.
Unmerged revisions
- 2515. By Diego Islas Ocampo
-
Keep consistency on permission labels
- 2514. By Diego Islas Ocampo
-
Remove unnecessary unowned declarations and improve no access labels
- 2513. By Diego Islas Ocampo
-
Remove explicit 'this' markers
- 2512. By Diego Islas Ocampo
-
Fix directory determination
- 2511. By Diego Islas Ocampo
-
Merge from trunk
- 2510. By Diego Islas Ocampo
-
Fix po merging issues
- 2509. By Diego Islas Ocampo
-
Replace permission grid buttons with comboboxes
- 2508. By Diego Islas Ocampo
-
Remove unnecessary parameters
- 2507. By Diego Islas Ocampo
-
Add different permission labels to folders
Some minor code style issues (see inline) comments. Also needs merging with latest trunk to remove irrelevant diff contents.
The code is otherwise OK for this solution, however UX input is needed on the wording and whether this is an acceptable interim solution. The word "Modify" is problematic - it implies you can modify the files inside but you can only create and delete them. I am not sure what single word would convey this and "Create/Delete files" would be too long. Ideally, the buttons need replacing with comboboxes as per Dan's mockup in the bug report. This would allow space for more meaningful descriptions of the permissions on directories. However, that is not strictly within the scope of the bitesize bug. Maybe use tooltips for the buttons?