Code review comment for lp://staging/~huwshimi/launchpad/privacy-notification-firefox-753423

Revision history for this message
Huw Wilkins (huwshimi) wrote :

I figured out the issue was actually that Firefox only understands CSS properties that have been converted to camel case. I've reverted all my changes and have fixed it with this simple change.

> Thanks for fixing this. It's a pity though that this could only be fixed by
> using setStyle. The class approach is so much cleaner.

It's back to using classes.

> There is still a little glitch in Firefox. Set a bug to "private", dismiss the
> notification at the top and the background color of "This bug report is
> private" box changes. Now change it back to public and the box will briefly
> turn white again, only to return to dark red again (but the text remains
> black).

Fixed.

> Finally, a note about the cover letter. I would have appreciated more context
> information and most importantly a hint about the necessary feature flag. Also
> a demo URL would have been nice. I could only gather that this is on a bugs
> page by reading the diff. Do you know the cover letter template like it is
> produced by "bzr lp-propose"?

Sorry about that I had been talking to someone about the issue and was hoping they would review it. I guess I was being lazy.

I did not know about lp-propse. I'll take a look.

« Back to merge proposal