Code review comment for lp://staging/~huwshimi/launchpad/privacy-notification-firefox-753423

Thanks for fixing this. It's a pity though that this could only be fixed by using setStyle. The class approach is so much cleaner.

There is still a little glitch in Firefox. Set a bug to "private", dismiss the notification at the top and the background color of "This bug report is private" box changes. Now change it back to public and the box will briefly turn white again, only to return to dark red again (but the text remains black).

Finally, a note about the cover letter. I would have appreciated more context information and most importantly a hint about the necessary feature flag. Also a demo URL would have been nice. I could only gather that this is on a bugs page by reading the diff. Do you know the cover letter template like it is produced by "bzr lp-propose"?

Still, the code looks good. Although the functionality still needs fixing before the feature can go public.